-
-
Notifications
You must be signed in to change notification settings - Fork 940
Fix PR-3864 (missing persistence) #3915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
tryBuild failed: |
@nextgens Unclear to me how to adapt the Database for the test. Thought that adjusting the Model in Models.py should suffice… |
You need a migration too; see https://mailu.io/2024.06/contributors/database.html You should really test this out locally before sending a PR for review; If you need assistance join #mailu-dev on https://app.element.io/#/room/#mailu-dev:matrix.org |
bors retry |
🔒 Permission denied Existing reviewers: click here to make DaCHack a reviewer |
Added the migration. In the dev environment it works fine now. Can you please trigger the CI so I can test it with a live full stack using |
bors try |
tryBuild succeeded: |
@nextgens I noticed that the --invisible option seems to be a global option only and cannot be applied to individual polls in the fetchmailrc file. I hope I did understand this correct since documentation is very limited on this option. Suggest to run |
bors try |
🔒 Permission denied Existing reviewers: click here to make DaCHack a reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I have two small changes.
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Pull request has been modified.
bors try |
tryBuild succeeded: |
Pull request has been modified.
@ghostwheel42 Thanks. Would You do another Bord try for me please? Testing revealed a remaining reference to the old invisible flag and Makes the admin Container Crash. Fixed now |
bors try |
tryBuild succeeded: |
What type of PR?
Bug-fix
What does this PR do?
Fixes missing persistence of the user Option „invisible“ from PR3864
Sorry for Spamming PRs. Just noticed that the user settings are Not persistent without adapting the data Model accordingly as well.