Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

DaCHack
Copy link
Contributor

@DaCHack DaCHack commented Sep 7, 2025

What type of PR?

Bug-fix

What does this PR do?

Fixes missing persistence of the user Option „invisible“ from PR3864

Sorry for Spamming PRs. Just noticed that the user settings are Not persistent without adapting the data Model accordingly as well.

Copy link
Contributor

mergify bot commented Sep 7, 2025

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors-mailu bot added a commit that referenced this pull request Sep 7, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Sep 7, 2025

try

Build failed:

@DaCHack
Copy link
Contributor Author

DaCHack commented Sep 7, 2025

@nextgens Unclear to me how to adapt the Database for the test. Thought that adjusting the Model in Models.py should suffice…

@nextgens
Copy link
Contributor

nextgens commented Sep 8, 2025

You need a migration too; see https://mailu.io/2024.06/contributors/database.html

You should really test this out locally before sending a PR for review; If you need assistance join #mailu-dev on https://app.element.io/#/room/#mailu-dev:matrix.org

@DaCHack
Copy link
Contributor Author

DaCHack commented Sep 27, 2025

bors retry

@bors-mailu
Copy link
Contributor

bors-mailu bot commented Sep 27, 2025

🔒 Permission denied

Existing reviewers: click here to make DaCHack a reviewer

@DaCHack
Copy link
Contributor Author

DaCHack commented Sep 27, 2025

You need a migration too; see https://mailu.io/2024.06/contributors/database.html

You should really test this out locally before sending a PR for review; If you need assistance join #mailu-dev on https://app.element.io/#/room/#mailu-dev:matrix.org

Added the migration. In the dev environment it works fine now. Can you please trigger the CI so I can test it with a live full stack using ${MAILU_VERSION:-pr-3915}, please @nextgens ?

@nextgens
Copy link
Contributor

bors try

bors-mailu bot added a commit that referenced this pull request Sep 27, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Sep 27, 2025

try

Build succeeded:

@DaCHack
Copy link
Contributor Author

DaCHack commented Sep 27, 2025

@nextgens I noticed that the --invisible option seems to be a global option only and cannot be applied to individual polls in the fetchmailrc file. I hope I did understand this correct since documentation is very limited on this option.
Thus, I reverted the changes of the PR and introduced a switch via environment variables in fetchmail.py
I remember we did not want to introduce additional ENV, but there are no global settings in the UI which could include a switch only available to the administrator.

Suggest to run bors try again for me to test the ENV in a full stack again and create a documentation entry afterwards if this works.

@DaCHack
Copy link
Contributor Author

DaCHack commented Sep 28, 2025

bors try

@bors-mailu
Copy link
Contributor

bors-mailu bot commented Sep 28, 2025

🔒 Permission denied

Existing reviewers: click here to make DaCHack a reviewer

Copy link
Contributor

@ghostwheel42 ghostwheel42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have two small changes.

optional/fetchmail/fetchmail.py Outdated Show resolved Hide resolved
optional/fetchmail/fetchmail.py Outdated Show resolved Hide resolved
DaCHack and others added 2 commits September 29, 2025 21:39
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
@mergify mergify bot dismissed ghostwheel42’s stale review September 29, 2025 19:40

Pull request has been modified.

@ghostwheel42
Copy link
Contributor

bors try

bors-mailu bot added a commit that referenced this pull request Sep 30, 2025
ghostwheel42
ghostwheel42 previously approved these changes Sep 30, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Sep 30, 2025

try

Build succeeded:

@mergify mergify bot dismissed ghostwheel42’s stale review October 4, 2025 14:15

Pull request has been modified.

@DaCHack
Copy link
Contributor Author

DaCHack commented Oct 4, 2025

@ghostwheel42 Thanks. Would You do another Bord try for me please? Testing revealed a remaining reference to the old invisible flag and Makes the admin Container Crash. Fixed now

@ghostwheel42
Copy link
Contributor

bors try

bors-mailu bot added a commit that referenced this pull request Oct 4, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Oct 4, 2025

try

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.