Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

DjVinnii
Copy link
Contributor

What type of PR?

enhancement

What does this PR do?

Resolve the LegacyKeyValueFormat and JSONArgsRecommended build checks.

https://docs.docker.com/reference/build-checks/

Prerequisites

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • In case of feature or enhancement: documentation updated accordingly
  • Unless it's docs or a minor change: add changelog entry file.

Copy link
Contributor

mergify bot commented Mar 29, 2025

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors-mailu bot added a commit that referenced this pull request Mar 29, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Mar 29, 2025

try

Build succeeded:

@nextgens
Copy link
Contributor

what about adding a "build-check" step in the CI too?

@DjVinnii
Copy link
Contributor Author

what about adding a "build-check" step in the CI too?

Apparently I never did this, my bad. I never really worked on developing CI in GitHub Actions, so I might need some guidance. According to the Docker documentation it should be as straight forward as I just commited.

@nextgens
Copy link
Contributor

bors try

bors-mailu bot added a commit that referenced this pull request Aug 12, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Aug 12, 2025

try

Timed out.

@nextgens
Copy link
Contributor

bors try

bors-mailu bot added a commit that referenced this pull request Aug 13, 2025
@DjVinnii
Copy link
Contributor Author

I see the following error happening in the CI:

docker/build-push-action@v6 is not allowed to be used in Mailu/Mailu. Actions in this workflow must be: within a repository owned by Mailu, created by GitHub, or matching the following: actions/checkout@v*, aszc/change-string-case-action@*, chetan/git-restore-mtime-action@v*, crazy-max/ghaction-github-runtime@*, dessant/lock-threads@v*, docker/bake-action@*, docker/login-action@*, docker/setup-buildx-action@*, docker/setup-qemu-action@*, ncipollo/release-action@v*, nick-fields/retry@v*, satackey/action-docker-layer-caching@*.

I'll have a look later today to see how to fix this. I suspect I need to use the docker/bake-action instead of the docker/buil-push-action

@nextgens
Copy link
Contributor

I am not sure where this is set; it may be a setting of the repository... to ensure we don't use actions we haven't reviewed.

@Diman0 can you shime some light on this please?

@bors-mailu
Copy link
Contributor

bors-mailu bot commented Aug 13, 2025

try

Timed out.

@nextgens
Copy link
Contributor

I have whitelisted docker/build-push-action... let's see

bors try

@Diman0
Copy link
Member

Diman0 commented Aug 13, 2025

bors try

@bors-mailu
Copy link
Contributor

bors-mailu bot commented Aug 13, 2025

try

Already running a review

@Diman0
Copy link
Member

Diman0 commented Aug 13, 2025

bors try-

@Diman0
Copy link
Member

Diman0 commented Aug 13, 2025

bors try

bors-mailu bot added a commit that referenced this pull request Aug 13, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Aug 13, 2025

try

Build failed:

@nextgens
Copy link
Contributor

@DjVinnii it's now working as intended; this is for you to fix :)

ghostwheel42
ghostwheel42 previously approved these changes Oct 11, 2025
Copy link
Contributor

@ghostwheel42 ghostwheel42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nextgens nextgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the CI and needs fixing.

You need to tell the check task which dockerfiles to validate

@ghostwheel42
Copy link
Contributor

bors try

@mergify mergify bot dismissed ghostwheel42’s stale review October 11, 2025 13:21

Pull request has been modified.

@bors-mailu
Copy link
Contributor

bors-mailu bot commented Oct 11, 2025

try

Build failed:

@ghostwheel42
Copy link
Contributor

bors try

bors-mailu bot added a commit that referenced this pull request Oct 12, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Oct 12, 2025

try

Build failed:

@ghostwheel42
Copy link
Contributor

bors try

bors-mailu bot added a commit that referenced this pull request Oct 12, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Oct 12, 2025

try

Build failed:

@ghostwheel42
Copy link
Contributor

bors try

bors-mailu bot added a commit that referenced this pull request Oct 12, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Oct 12, 2025

try

Build failed:

@ghostwheel42
Copy link
Contributor

bors try

bors-mailu bot added a commit that referenced this pull request Oct 12, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Oct 12, 2025

try

Build failed:

@ghostwheel42
Copy link
Contributor

bors try

bors-mailu bot added a commit that referenced this pull request Oct 12, 2025
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Oct 12, 2025

try

Build failed:

@ghostwheel42
Copy link
Contributor

bors try

@bors-mailu
Copy link
Contributor

bors-mailu bot commented Oct 12, 2025

try

Merge conflict.

@ghostwheel42
Copy link
Contributor

bors try

@bors-mailu
Copy link
Contributor

bors-mailu bot commented Oct 12, 2025

try

Merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.