-
-
Notifications
You must be signed in to change notification settings - Fork 940
fix: Resolve LegacyKeyValueFormat and JSONArgsRecommended #3811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
tryBuild succeeded: |
what about adding a "build-check" step in the CI too? |
Apparently I never did this, my bad. I never really worked on developing CI in GitHub Actions, so I might need some guidance. According to the Docker documentation it should be as straight forward as I just commited. |
bors try |
tryTimed out. |
bors try |
I see the following error happening in the CI:
I'll have a look later today to see how to fix this. I suspect I need to use the |
I am not sure where this is set; it may be a setting of the repository... to ensure we don't use actions we haven't reviewed. @Diman0 can you shime some light on this please? |
tryTimed out. |
I have whitelisted docker/build-push-action... let's see bors try |
bors try |
tryAlready running a review |
bors try- |
bors try |
tryBuild failed: |
@DjVinnii it's now working as intended; this is for you to fix :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the CI and needs fixing.
You need to tell the check task which dockerfiles to validate
bors try |
Pull request has been modified.
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryMerge conflict. |
bors try |
tryMerge conflict. |
What type of PR?
enhancement
What does this PR do?
Resolve the LegacyKeyValueFormat and JSONArgsRecommended build checks.
https://docs.docker.com/reference/build-checks/
Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.