Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

try commit 3cdfe33610851ee which has better resiliance to per-thread …#66

Closed
mattip wants to merge 1 commit intomasterMacPython/openblas-libs:masterfrom
try-new-thread-allocMacPython/openblas-libs:try-new-thread-allocCopy head branch name to clipboard
Closed

try commit 3cdfe33610851ee which has better resiliance to per-thread …#66
mattip wants to merge 1 commit intomasterMacPython/openblas-libs:masterfrom
try-new-thread-allocMacPython/openblas-libs:try-new-thread-allocCopy head branch name to clipboard

Conversation

@mattip
Copy link
Collaborator

@mattip mattip commented Sep 1, 2021

…allocations

@mattip mattip mentioned this pull request Sep 1, 2021
Merged
@mattip
Copy link
Collaborator Author

mattip commented Sep 1, 2021 •
edited
Loading

This is a new error on windows. Is the command line too long?

gcc -O2 -march=x86-64 -mtune=generic -fno-asynchronous-unwind-tables -DSMALL_MATRIX_OPT \
-DMS_ABI -DMAX_STACK_ALLOC=2048 -Wall -m64 -DF_INTERFACE_GFORT  -DDYNAMIC_ARCH \
-DSMP_SERVER -DNO_WARMUP -DCONSISTENT_FPCSR -DBUFFERSIZE=20 -DMAX_CPU_NUMBER=24 \ 
-DMAX_PARALLEL_NUMBER=1 -DBUILD_SINGLE=1 -DBUILD_DOUBLE=1 -DBUILD_COMPLEX=1 \
 -DBUILD_COMPLEX16=1 -DVERSION=\"0.3.17.dev\" -msse3 -UASMNAME -UASMFNAME -UNAME -UCNAME \
 -UCHAR_NAME -UCHAR_CNAME -DASMNAME=cgemm_small_kernel_cc_PRESCOTT \ 
-DASMFNAME=cgemm_small_kernel_cc_PRESCOTT_ -DNAME=cgemm_small_kernel_cc_PRESCOTT_ \
-DCNAME=cgemm_small_kernel_cc_PRESCOTT -DCHAR_NAME=\"cgemm_small_kernel_cc_PRESCOTT_\" \
-DCHAR_CNAME=\"cgemm_small_kernel_cc_PRESCOTT\" -DNO_AFFINITY -DTS=_PRESCOTT -I.. -DBUILD_KERNEL \
-DTABLE_NAME=gotoblas_PRESCOTT -UDOUBLE  -DCOMPLEX -c -UDOUBLE -DCOMPLEX -DCC \
../kernel/x86_64/../generic/zgemm_small_matrix_kernel_tt.c -o cgemm_small_kernel_cc_PRESCOTT.obj

<command-line>: error: expected identifier or '(' before numeric constant

Edit: no, it is 917 characters when the limit is 8191. So not a command line-length problem.

@martin-frbg
Copy link

martin-frbg commented Sep 1, 2021

Oops. That must have been introduced by the recent "small gemm" kernel patch (though I wonder why it did not break the OpenBLAS CI jobs). Basically it is a known symbol clash with a "CR" macro defined in winnt.h, the proven workaround is to
change the "-DCR" in affected Makefiles to "-DCR=CR". I'll prepare a PR ASAP.

@mattip
Copy link
Collaborator Author

mattip commented Sep 1, 2021

Thanks. I learned something new.

@mattip
Copy link
Collaborator Author

mattip commented Mar 16, 2022

Obsolete. Closing.

@mattip mattip closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattip @martin-frbg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.