Add a step for smoothing topograpy #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmooremaley
reviewed
Feb 7, 2025
ab54706 to
4b79fd4
Compare
4b79fd4 to
e401cfb
Compare
Collaborator
Author
TestingI ran the Icos240 mesh, init and performance tests using a smoothing factor of 2. I looked at the results in ParaVeiw and the smoothing was visible in the bed_elevation field. I also saw that the topography had been remapped in the step with smoothing (whereas it should just be symlinked if there is no smoothing). I'm not yet able to run the |
We remap the topography once without smoothing and then once with smoothing. The unsmoothed topography is used to determine the land mask, thus allowing many meshes with different levels of smoothing to have the same mapping files in E3SM. For the time being, only two simple types of smoothing are supported: a smoothing over a fixed distance or by expanding cells by a fixed fraction. (The two types of smoothing can also be used at the same time.) In the future, maps with non-uniform smoothing could be added for finer control. A check use used to bypass the second smoothing pass if, in fact, no smoothing is requested (the default behavior).
e401cfb to
1ddefe4
Compare
0673248 to
ae23e37
Compare
Collaborator
Author
TestingI successfully ran the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remap the topography once without smoothing and then once with smoothing. The unsmoothed topography is used to determine the land mask, thus allowing many meshes with different levels of smoothing to have the same mapping files in E3SM.
For the time being, only two simple types of smoothing are supported: a smoothing over a fixed distance or by expanding cells by a fixed fraction. (The two types of smoothing can also be used at the same time.)
In the future, maps with non-uniform smoothing could be added for finer control.
A check is used to bypass the second smoothing pass if, in fact, no smoothing is requested (the default behavior).
Checklist
Testingin this PR) any testing that was used to verify the changes