Fix nonhydro documentation #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
TestingI built the docs locally and (after fixing an indentation issue in the API) everything looks good now. |
This merge also includes a fix to the Chicoma docs
Collaborator
Author
|
@cbegeman and @scalandr, I think we were all a bit exhausted in #374 and a few glitches in the documentation crept in at the end. This is to fix those (because they're making it hard to have correct documentation in other PRs). Please take a glance at my fixes and make sure there's nothing obviously wrong. No need to build locally or anything. Please approve today or tomorrow if you can because I want to rebase #525 onto this fix. |
scalandr
approved these changes
Feb 8, 2023
Collaborator
scalandr
left a comment
There was a problem hiding this comment.
Hi Xylar, I looked at your changes and could not see anything obviously wrong, so I approved the request.
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge also includes a fix to the Chicoma docs
Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes