Fix handling of ntasks = 1 for single node #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omitting `-n 1` (as was done previously) means the step runs on all cores, not just 1.
mperego
approved these changes
Jan 18, 2023
Contributor
mperego
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
Collaborator
Author
|
@mperego, I haven't been able to test this myself because I'm not able to get MPAS-Ocean to run on linux right now at all (unrelated to this issue). If you are able to test and this works for you, please report back and I'll merge. I don't want to merge without any testing at all. |
Contributor
|
@xylar I tested it and it works for me. |
Collaborator
Author
|
Okay, great! I'll merge and test it myself when I can run on linux again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitting
-n 1(as was done previously) means the step runs on all cores, not just 1.Checklist
Testingin this PR) any testing that was used to verify the changescloses #507