Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update shapely, geometric_features and mpas_tools #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xylar merged 1 commit into from
Jan 5, 2023
Merged

Update shapely, geometric_features and mpas_tools #490

xylar merged 1 commit into from
Jan 5, 2023

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Dec 30, 2022 •
edited
Loading

New versions are needed to support shapely >=2.0

The only code in compass itself that uses shapely is for generating MISOMIP output from the isomip_plus test cases. As this is rarely used, a considerable amount of work to test, and the calls did not look likely to be affected by the change in shapely, I will not test that part of the code here.

Checklist

  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added the dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script label Dec 30, 2022
@xylar xylar self-assigned this Dec 30, 2022
@xylar
Copy link
Collaborator Author

xylar commented Dec 30, 2022

Testing

I ran the pr test suite on Chrysalis with Intel and OpenMPI, using the current main branch as a baseline. I used local builds of the new geometric_features 1.0.0 and mpas_tools 0.16.0 as those have not yet been released. To my pleasant surprise, all results are bit-for-bit. I thought some of the mask creation in MPAS-Tools might have changed with the new shapely.

Results are in:

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20221230/pr_shapely_2.0

@xylar xylar mentioned this pull request Jan 4, 2023
Merged
@xylar xylar force-pushed the support_shapely_2.0 branch from 3d7390c to 011d61b Compare January 5, 2023 19:51
@xylar
Update shapely, geometric_features and mpas_tools
42d5767 
New versions are needed to support shapely >=2.0
@xylar xylar force-pushed the support_shapely_2.0 branch from 011d61b to 42d5767 Compare January 5, 2023 20:06
@xylar xylar marked this pull request as ready for review January 5, 2023 20:30
@xylar xylar merged commit 68a6dcf into MPAS-Dev:main Jan 5, 2023
@xylar xylar deleted the support_shapely_2.0 branch January 6, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@xylar xylar

Labels

dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xylar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.