Give log path for failed tests only in suite #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When test cases are run on their own, they don't put a log file in `case_outputs` so we shouldn't incorrectly point to one.
0ec2753 to
ead3f71
Compare
Collaborator
Author
TestingI ran the I ran a single test in its work directory (deliberately causing it to fail) and saw the expected stack trace and error message but not the message about a log file in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When test cases are run on their own, they don't put a log file in
case_outputsso we shouldn't incorrectly point to one.This merge also clean things up by converting calls to the
.format()method to f-strings.closes #398