Add koge bugt s test group #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test group for Koge Bugt S, Greenland. This contains a single mesh creation test case. This test case works as desired, but documentation still needs to be updated.
Add docs for Koge Bugt S mesh generation test case. Also change default minimum grid spacing from 1km to 500m.
Change Koge Bugt S maximum grid spacing from 10 km to 4km to avoid omitting the narrow up-glacier part of the catchment.
84a74cb to
8e8996e
Compare
Collaborator
Author
matthewhoffman
approved these changes
May 11, 2022
Member
matthewhoffman
left a comment
There was a problem hiding this comment.
Looks good! Thanks for taking the extra time to add this experimental mesh to COMPASS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test group for Koge Bugt S, Greenland. This will provide a useful way to work out issues related to narrow fjords on a small and affordable mesh. This contains a single mesh creation test case.