Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Disable timing in scorpio build #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xylar merged 2 commits into from
Apr 20, 2022
Merged

Disable timing in scorpio build #367

xylar merged 2 commits into from
Apr 20, 2022

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Apr 20, 2022

This seems to be a problem with standalone MPAS builds. It was introduced in #359, apparently with insufficient testing.

Part of this fix is some patching of SCORPIO 1.3.2 in our spack branch.

@xylar xylar added bug Something isn't working dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script labels Apr 20, 2022
@xylar xylar self-assigned this Apr 20, 2022
@pep8speaks
Copy link

pep8speaks commented Apr 20, 2022

Hello @xylar! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 308:80: E501 line too long (86 > 79 characters)

@xylar
Copy link
Collaborator Author

xylar commented Apr 20, 2022 •
edited
Loading

Testing

This passes the ocean pr test suite on Anvil with Intel and Intel-MPI, and the MALI full_integration test suite with Gnu and MVAPICH on both Anvil. I'm working on the same test on Badger. The baseline was from compass before SCORPIO 1.3.2 was added.

Update: Badger MALI tests also passed!

@xylar
Copy link
Collaborator Author

xylar commented Apr 20, 2022 •
edited
Loading

Deployment

I have deployed the following machines and configurations:

  • Anvil intel impi
  • Anvil intel openmpi
  • Anvil intel mvapich
  • Anvil gnu openmpi
  • Anvil gnu mvapich
  • Badger intel impi
  • Badger gnu mvapich
  • Chrysalis intel impi
  • Chrysalis intel openmpi
  • Chrysalis gnu openmpi
  • Compy intel impi
  • Cori-Haswell intel mpt
  • Cori-Haswell gnu mpt

@xylar xylar merged commit f37cad7 into MPAS-Dev:master Apr 20, 2022
@xylar xylar deleted the fix_scorpio branch April 20, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@xylar xylar

Labels

bug Something isn't working dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xylar @pep8speaks
Morty Proxy This is a proxified and sanitized view of the page, visit original site.