Add a stack to the init_atmosphere core #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
A companion repository has also been setup, https://github.com/MiCurry/mpas_stack to help test for memory leaks. |
15b504b to
8b5cbb1
Compare
Contributor
Author
|
@mgduda I think this is good to go, at least for inspection. I've compiled with Intel, GNU and PGI, and tested with Intel and GNU. I'm working on testing with PGI. There is a single pitfall when using polymorphic types and the Intel compiler (which I think we've ran into and discussed before). With GNU, you can define your item as a Which appears to be a bug. The workaround (as Doctor Fortran posted), is to use |
mgduda
reviewed
Jan 24, 2020
mgduda
reviewed
Jan 24, 2020
mgduda
reviewed
Jan 24, 2020
Contributor
|
@MiCurry Functionally, I think the module looks good. Besides a bit of clean-up, I'd just like to push for a renaming of the derived types. |
3f98327 to
3896194
Compare
Contributor
Author
|
Okay, @mgduda, I've made those changes that you requested in terms of clean-up and renamed the derived types as we discussed above! So I think this PR is good to go! |
mgduda
reviewed
Jan 27, 2020
mgduda
reviewed
Jan 27, 2020
mgduda
reviewed
Jan 27, 2020
mgduda
reviewed
Jan 27, 2020
mgduda
reviewed
Jan 27, 2020
mgduda
reviewed
Jan 27, 2020
mgduda
reviewed
Jan 27, 2020
mgduda
reviewed
Jan 27, 2020
mgduda
reviewed
Jan 27, 2020
This commit adds a new module to the MPAS init_atmosphere core, mpas_stack, which is a simple stack implementation. At current, this module is not being used by any part of the init_atmosphere core.
3896194 to
354c5c3
Compare
Contributor
Author
|
@mgduda Okay, those changes have been made! |
mgduda
added a commit
that referenced
this pull request
Jan 30, 2020
This merge adds a new module to the MPAS init_atmosphere core, mpas_stack, which is a simple and extensible stack implementation. It uses Fortran 2003 polymorphism to allow different 'payloads' to be pushed and popped on a stack; thus it can be used for a number of applications. At present, this module is not being used by any part of the init_atmosphere core, but future code could make use of its features. * init_atmosphere/mpas_stack: Add mpas_stack to init_atmosphere core
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jul 27, 2020
#3737) Update MPAS framework This PR brings in a new mpas-source submodule with updates to the mpas framework itself, plus changes to the cores supporting the framework update. Some changes are made to the atmosphere core, even though it is not used by E3SM, in order to maintain consistency with the framework. This update includes the following individual branches and PRs, many of which are additions to the makefiles for summit, or optional libraries: * az/azamat/mpas-cmake/mpas-tool-dir (MPAS-Dev/MPAS-Model#629) * init_atmosphere/kd_tree_ties (MPAS-Dev/MPAS-Model#630) * mark-petersen/framework/add_FillValue (MPAS-Dev/MPAS-Model#616) * mark-petersen/framework/add_lapack_option (MPAS-Dev/MPAS-Model#613) * amametjanov/framework/nullify-field-pointers (MPAS-Dev/MPAS-Model#578) * framework/makefile_e3sm (MPAS-Dev/MPAS-Model#603) * xylar/framework/make_shell_bash (MPAS-Dev/MPAS-Model#594) * registry/missing_value (MPAS-Dev/MPAS-Model#562) * pwolfram/updates_make_intel_stack (MPAS-Dev/MPAS-Model#592) * azamat/framework/pgi-cpr-omp-workaround (MPAS-Dev/MPAS-Model#449) * az/framework/e3sm-cmake-qnosmp-typo (MPAS-Dev/MPAS-Model#579) * xylar/compass/add_prerequisite_tag * atmosphere/fix_timekeeping_imports (MPAS-Dev/MPAS-Model#582) * xylar/fix_docs_ci (MPAS-Dev/MPAS-Model#575) * xylar/add_compass_docs (MPAS-Dev/MPAS-Model#472) * philipwjones/framework/summitmake (MPAS-Dev/MPAS-Model#536) * atmosphere/atm_core_cleanup (MPAS-Dev/MPAS-Model#548) * init_atmosphere/parse_geoindex (MPAS-Dev/MPAS-Model#459) * xylar/compass/add_copy_file (MPAS-Dev/MPAS-Model#467) * init_atmosphere/kd_tree (MPAS-Dev/MPAS-Model#438) * init_atmosphere/mpas_stack (MPAS-Dev/MPAS-Model#426) * operators/add_mpas_in_cell (MPAS-Dev/MPAS-Model#400) Fixes #3396 Fixes #3236 [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jul 29, 2020
Update MPAS framework This PR brings in a new mpas-source submodule with updates to the mpas framework itself, plus changes to the cores supporting the framework update. Some changes are made to the atmosphere core, even though it is not used by E3SM, in order to maintain consistency with the framework. This update includes the following individual branches and PRs, many of which are additions to the makefiles for summit, or optional libraries: * az/azamat/mpas-cmake/mpas-tool-dir (MPAS-Dev/MPAS-Model#629) * init_atmosphere/kd_tree_ties (MPAS-Dev/MPAS-Model#630) * mark-petersen/framework/add_FillValue (MPAS-Dev/MPAS-Model#616) * mark-petersen/framework/add_lapack_option (MPAS-Dev/MPAS-Model#613) * amametjanov/framework/nullify-field-pointers (MPAS-Dev/MPAS-Model#578) * framework/makefile_e3sm (MPAS-Dev/MPAS-Model#603) * xylar/framework/make_shell_bash (MPAS-Dev/MPAS-Model#594) * registry/missing_value (MPAS-Dev/MPAS-Model#562) * pwolfram/updates_make_intel_stack (MPAS-Dev/MPAS-Model#592) * azamat/framework/pgi-cpr-omp-workaround (MPAS-Dev/MPAS-Model#449) * az/framework/e3sm-cmake-qnosmp-typo (MPAS-Dev/MPAS-Model#579) * xylar/compass/add_prerequisite_tag * atmosphere/fix_timekeeping_imports (MPAS-Dev/MPAS-Model#582) * xylar/fix_docs_ci (MPAS-Dev/MPAS-Model#575) * xylar/add_compass_docs (MPAS-Dev/MPAS-Model#472) * philipwjones/framework/summitmake (MPAS-Dev/MPAS-Model#536) * atmosphere/atm_core_cleanup (MPAS-Dev/MPAS-Model#548) * init_atmosphere/parse_geoindex (MPAS-Dev/MPAS-Model#459) * xylar/compass/add_copy_file (MPAS-Dev/MPAS-Model#467) * init_atmosphere/kd_tree (MPAS-Dev/MPAS-Model#438) * init_atmosphere/mpas_stack (MPAS-Dev/MPAS-Model#426) * operators/add_mpas_in_cell (MPAS-Dev/MPAS-Model#400) Fixes #3396 Fixes #3236 [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new module to the MPAS init_atmosphere core, mpas_stack, which is a simple and extensible stack implementation. It uses Fortran 2003's polymorphic features to allow different 'payloads' to be associated with a stack; thus it can be used for a number of applications.
At current, this module is not being used by any part of the init_atmosphere core, but a future PR could make use of its features.
A copy of
mpas_init_atm_core.F, that uses and contains tests for mpas_stack.F, has been uploaded as a gist, https://gist.github.com/MiCurry/22ad2085f0ba10e325d96449a97a8434, which can be used to test mpas_stack.F.