Remove redundant query of nCellsSolve dimension in physics_run_init #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The physics_run_init routine in the mpas_atmphys_manager module contained a redundant query of the nCellsSolve dimension from the mesh pool. This commit simply removes the extra query.
gdicker1
approved these changes
Sep 20, 2024
Collaborator
gdicker1
left a comment
There was a problem hiding this comment.
Approved by inspection
Contributor
|
Approved by inspection as well. |
mgduda
added a commit
that referenced
this pull request
Sep 20, 2024
This merge addresses several issues in the MPAS-Atmosphere model and in the MPAS infrastructure. Specific changes in this merge include: * Fix to a portability issue in the MPAS registry 'parse' tool, which caused files in the src/core_<CORE>/inc directory to not be generated correctly at build time on some systems (PR #1229). * Addition of two fields, brtemp and cldmask, that are needed by MPAS-JEDI. Although not needed by stand-alone MPAS-Atmosphere, these fields are associated with the 'jedi_da' package and therefore have no effect when MPAS-Atmosphere is run without setting config_jedi_da = true (PR #1232). * Removal of a redundant query of the nCellsSolve dimension in the physics_run_init routine. The extra query had no impact on results, and its removal can be considered clean-up (PR #1236).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a redundant query of the
nCellsSolvedimension in thephysics_run_initroutine.The
physics_run_initroutine in thempas_atmphys_managermodule contained a redundant query of thenCellsSolvedimension from themeshpool, which has been removed by this PR with no impact on simulations.