Bug fix to for MYNN PBL option with Thompson cloud microphysics #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> removed package bl_mynn_in from packages included for nc and tend_nc. the
array declaration for nc, nifa, nwfa, tend_nc, tend_nifa, and tend_nwfa
now includes the same packages.
-> in ./physics/mpas_atmphys_interface.F, added arrays nifa_p, and nwfa_p for
the PBL option "bl_mynn".
-> in ./physics/mpas_atmphys_todynamics.F, only updates tend_scalars(index_nc,
tend_scalars(index_nifa, and tend_scalars(index_nwfa due to PBL processes
when the microp_scheme option is "mp_thompson_aerosols".
These changes are needed to run the MYNN PBL scheme without the aerosol-aware
option of the Thompson cloud microphysics scheme.
mgduda
approved these changes
Aug 7, 2024
mgduda
added a commit
that referenced
this pull request
Aug 7, 2024
This merge addresses several issues in the MPAS-Atmosphere model and in the MPAS infrastructure. Specific changes in this merge include: * Improved detection of an 'mpi_f08' module (PR #1202), as well as improved detection of netCDF and PnetCDF library paths (PR #1203), in the top-level Makefile. * The addition of a missing dependency in the physics Makefile to correct parallel build issues (PR #1204). * Fixes to the CMake build files used by MPAS-JEDI (PR #1205). * Fixes to double-precision builds of MPAS-Atmosphere (PR #1207, PR #1208). * Correction of the calculation of height AGL used in the computation of 1-km radar reflectivity fields (PR #1213). * Correction of an issue that prevented the MYNN PBL scheme from being used without also using the Thompson aerosol-aware microphysics (PR #1215). * Fixes to allow MPAS-Atmosphere to be built without physics (i.e., dynamics- only builds) (PR #1221). * Various code cleanup and minor corrections (PR #1206, PR #1212, PR #1224, PR #1226).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running ./atmosphere_model with the convection_permitting suite, forecasts crash because we update the arrays tend_scalars(index_nc,...), tend_scalars(index_nifa,...) , and tend_scalars(index_nwfa,...) in mpas_atmphys_todynamics when they have not been allocated. Note that these arrays are only allocated when we run the aerosol-aware option of the
Thompson cloud microphysics scheme (microp_scheme = mp_thompson_aerosols).
This error is fixed by ensuring that we only update these three arrays when we run the aerosol-aware option of the Thompson cloud microphysics scheme.