Update initialization for turbulent mixing layer and add validation results #879
+1,119
−1,259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbryngelson
reviewed
Jun 11, 2025
examples/3D_turb_mixing/turbulence_stat/results/Reynolds_stress/tstep_8064.png
Outdated
Show resolved
Hide resolved
sbryngelson
reviewed
Jun 11, 2025
examples/3D_turb_mixing/turbulence_stat/submit_batch_job_carpenter.sh
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #879 +/- ##
==========================================
- Coverage 45.64% 43.71% -1.93%
==========================================
Files 68 68
Lines 18646 18450 -196
Branches 2249 2238 -11
==========================================
- Hits 8511 8066 -445
- Misses 8775 9071 +296
+ Partials 1360 1313 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sbryngelson
reviewed
Jun 13, 2025
src/pre_process/m_start_up.fpp
Outdated
| @@ -38,7 +38,7 @@ module m_start_up | ||
|
|
||
| use m_helper | ||
|
|
||
| #ifdef MFC_MPI | ||
| #ifdef MFC_MP |
sbryngelson
reviewed
Jun 13, 2025
src/pre_process/m_start_up.fpp
Outdated
| @@ -10,7 +10,7 @@ module m_start_up | ||
|
|
||
| use m_derived_types !< Definitions of the derived types | ||
|
|
||
| use m_global_parameters !< Global parameters for the code | ||
| use m_global_parameters !< Global parameters for the codeI |
sbryngelson
reviewed
Jun 13, 2025
| set(gca,'TickLabelInterpreter','latex'); | ||
|
|
||
| % Pantano & Sarkar (2002) | ||
| load reference_data/Pantano_Sarkar_2002/production.dat; |
There was a problem hiding this comment.
we can't use this script because these data are unavailable. can you put the relevant data into one combined .dat (or .mat) file in this directory in version control? i assume the file will be small
There was a problem hiding this comment.
Sorry I thought I added them. I've added them now.
There was a problem hiding this comment.
I can put all of them in a single file. I will update this soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes an update on initialization method for turbulent mixing layer. Also, Matlab scripts for computing turbulence statistics are added to
examples/3D_turb_mixing/turbulence_statas well as validation results.Type of change
Please delete options that are not relevant.
Scope
If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.
How Has This Been Tested?
Ran
examples/3D_turb_mixingon CarpenterStreamwise velocity field at final time
Vorticity magnitude at final time
Evolution of Reynolds stress
Evolution of TKE budget
TKE budget averaged over self-similar period
Momentum thickness growth rate (see run_turbulence.m for references in legend)
Checklist
docs/)examples/that demonstrate my new feature performing as expected.They run to completion and demonstrate "interesting physics"
./mfc.sh formatbefore committing my code