-
Notifications
You must be signed in to change notification settings - Fork 105
Enable array reshaping for better inlining on NVHPC #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Currently, this compiles for when in debug mode, but fails to compile when in no-debug |
I would imagine that debug mode disables any inlining at all, certainly reshaping. That said, the error is strange. It fails compiling pre_process? pre_process doesn't use openacc statements... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
=======================================
Coverage 43.47% 43.47%
=======================================
Files 68 68
Lines 19766 19766
Branches 2375 2375
=======================================
Hits 8593 8593
Misses 9726 9726
Partials 1447 1447 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
here's the error:
|
Found this Your findings are correct: Consequences of Using
|
Description
Many functions were unable to be inlined by the NVHPC compiler because there was a reshape array option that was not enabled for inlining.
Fixes #(issue) [optional]
Type of change
Please delete options that are not relevant.
Scope
If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Test Configuration:
Checklist
docs/
)examples/
that demonstrate my new feature performing as expected.They run to completion and demonstrate "interesting physics"
./mfc.sh format
before committing my codeIf your code changes any code source files (anything in
src/simulation
)To make sure the code is performing as expected on GPU devices, I have:
nvtx
ranges so that they can be identified in profiles./mfc.sh run XXXX --gpu -t simulation --nsys
, and have attached the output file (.nsys-rep
) and plain text results to this PR./mfc.sh run XXXX --gpu -t simulation --rsys --hip-trace
, and have attached the output file and plain text results to this PR.