-
Notifications
You must be signed in to change notification settings - Fork 105
Refactor HLL, HLLC, HLLD Solvers #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The PR looks like it may have gotten some help from a GPT of some kind, which is fine. But make sure it compiles and passes tests on your local laptop or a cluster you have access to before submitting the PR. |
…ssed them in the calls
failed tests mostly Hypoelasticity Failed test tests/9EB947DB: 1D -> Hypoelasticity -> 1 Fluid(s) after 3 attempt(s). |
this is a hard one to refactor. i recommend doing HLL by itself first, which is shorter and involves less physics/edge cases. then if that works you can do HLLC. i already tried this on my own and think it isn't too bad. do things very incrementally and ensure you don't break things along the way. |
Sounds good, I will undo the changes to the solvers subroutines and go from there incrementally. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #855 +/- ##
==========================================
+ Coverage 43.47% 43.55% +0.07%
==========================================
Files 68 68
Lines 19766 19457 -309
Branches 2375 2333 -42
==========================================
- Hits 8593 8474 -119
+ Misses 9726 9575 -151
+ Partials 1447 1408 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Refactor Riemann Solvers and relevant subroutines
Fixes #(issue) [optional]
Type of change
Please delete options that are not relevant.
Scope
How Has This Been Tested?
./mfc.sh test
Test Configuration:
Locally
Checklist
docs/
)examples/
that demonstrate my new feature performing as expected.They run to completion and demonstrate "interesting physics"
./mfc.sh format
before committing my codeIf your code changes any code source files (anything in
src/simulation
)To make sure the code is performing as expected on GPU devices, I have:
nvtx
ranges so that they can be identified in profiles./mfc.sh run XXXX --gpu -t simulation --nsys
, and have attached the output file (.nsys-rep
) and plain text results to this PR./mfc.sh run XXXX --gpu -t simulation --rsys --hip-trace
, and have attached the output file and plain text results to this PR.