Improve error handling#4
Merged
LukeMathWalker merged 4 commits intoLukeMathWalker:histogram-error-handlingLukeMathWalker/ndarray-stats:histogram-error-handlingfrom Apr 1, 2019
rust-ndarray:histogram-error-handlingrust-ndarray/ndarray-stats:histogram-error-handlingCopy head branch name to clipboard
Merged
Improve error handling#4LukeMathWalker merged 4 commits intoLukeMathWalker:histogram-error-handlingLukeMathWalker/ndarray-stats:histogram-error-handlingfrom rust-ndarray:histogram-error-handlingrust-ndarray/ndarray-stats:histogram-error-handlingCopy head branch name to clipboard
LukeMathWalker merged 4 commits intoLukeMathWalker:histogram-error-handlingLukeMathWalker/ndarray-stats:histogram-error-handlingfrom
rust-ndarray:histogram-error-handlingrust-ndarray/ndarray-stats:histogram-error-handlingCopy head branch name to clipboard
Conversation
This is nice because it doesn't lose information. (Returning an `Option` combines the two error variants into a single case.)
Once the `#[non_exhaustive]` attribute is stable, we should replace the hidden enum variant with that attribute on the enum.
fafbfc5 to
f41b317
Compare
| } | ||
| _ => Ok(None), | ||
| } | ||
| let min = a.min()?; |
Owner
There was a problem hiding this comment.
This looks way cleaner now, it's nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rust-ndarray#25.