[5.2] Use toArray() for Model Object Value instead of Model attributes cast #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. :) |
|
Dennis - Can you write a test or explain the issue you're having with the way the code now?? I'm not sure what this is offering. Thanks, |
|
@adamgoose: This allows you to use reserved names for properties as well and prevents errors in case you do wish to use it (e.g. when using "attributes" in forms). |
adamgoose
added a commit
that referenced
this pull request
Jan 15, 2016
|
Hi @dennisoderwald, The tests are failing, Check your PR on Travis CI on this build and also this one. |
|
Dennis - just so so you know, I've reverted your PR. Let's talk on Slack today to find out what we can do for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.