Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

niosega
Copy link

@niosega niosega commented Jul 12, 2016

I try to implement the fact that a gauge can be clockwise. (like in a car for instance).

@niosega niosega mentioned this pull request Jul 12, 2016
@coveralls
Copy link

coveralls commented Jul 13, 2016

Coverage Status

Coverage decreased (-0.2%) to 92.961% when pulling 91a6ac2 on niosega:master into 1a1ce32 on Kozea:master.

@feargswalsh92
Copy link

@niosega We are working on this project for a University class,as a learning tool we added some tests to the code you wrote,and a couple of extra lines to the code,if you would like to add them to your fork and make a new pull request feel free,here is a link to the version of the Repository that involves the Gauge issue: https://github.com/ConnorMooreLUC/pygalfork/tree/766ec10a9ec1742b729ec25928141e4f07c383cf
Thanks,we learned a lot from analyzing the changes you made.

@niosega
Copy link
Author

niosega commented Jul 21, 2016

@feargswalsh92 You're welcome !
By the way, I have discuss with @paradoxxxzero and he said that my approach is not the best one. So I'll try another approach soon.
If you want to try to implement the new method, the idea is to modify the view (probably PolarView) in order to include the symmetry in the view function.

@y2kbugger
Copy link

@glepretre @paradoxxxzero

I'm preparing to put in a few pull requests for gauges, a bug fix and a feature add. Am I wrong or are gauges already go clockwise. Can this be closed, or should I look into what these devs were doing. I've I'm working on the ability to specify non-zero and negative min_value for gauges, so it does involve drawing the arcs in multiple directions.
image

@glepretre
Copy link
Contributor

@y2kbugger sorry but I'm just cleaning here 😬 (closing issues, etc) I don't know enough python and the project to answer

@y2kbugger
Copy link

I bet this can be closed, given that gauges are already clockwise now (maybe they weren't in 2016)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.