correct RestSharp snippets (return type and Method enum)#366
Merged
filfreire merged 1 commit intoKong:masterKong/httpsnippet:masterfrom Oct 1, 2024
Merged
correct RestSharp snippets (return type and Method enum)#366filfreire merged 1 commit intoKong:masterKong/httpsnippet:masterfrom
filfreire merged 1 commit intoKong:masterKong/httpsnippet:masterfrom
Conversation
|
|
michaelgwelch
commented
Sep 15, 2024
Ensure that code snippets use enum members that are pascal cased and not upper cased. For example use `Method.Get` instead of `Method.GET` to ensure the snippets can compile. fixes Kong#365 use `var` for return "type" of RestSharp request response The type `IRestResponse` doesn't exist in latest client (version 112) fixes Kong#367
cdd9781 to
17d38fa
Compare
filfreire
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that code snippets use enum members that are pascal cased and not upper cased. For example use
Method.Getinstead ofMethod.GETto ensure the snippets can compile.Also removes usage of unknown type
IRestResponsefixes #365 #367 #312