Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix uncompilable code of Java asynchttp#169

Merged
reynolek merged 1 commit intoKong:masterKong/httpsnippet:masterfrom
wtetsu:fix/uncompilable_java_asynchttp_codewtetsu/httpsnippet:fix/uncompilable_java_asynchttp_codeCopy head branch name to clipboard
Jul 22, 2020
Merged

Fix uncompilable code of Java asynchttp#169
reynolek merged 1 commit intoKong:masterKong/httpsnippet:masterfrom
wtetsu:fix/uncompilable_java_asynchttp_codewtetsu/httpsnippet:fix/uncompilable_java_asynchttp_codeCopy head branch name to clipboard

Conversation

@wtetsu
Copy link
Contributor

@wtetsu wtetsu commented Jun 20, 2020

I noticed, java/asynchttp/custom-method.java is not compilable because there is no preparePropfind method.

AsyncHttpClient client = new DefaultAsyncHttpClient();
client.preparePropfind("http://mockbin.com/har")

I unified code style from client.prepareMethod(url) to client.prepare("METHOD", url) because internal code of DefaultAsyncHttpClient is like this.

    public BoundRequestBuilder prepare(String method, String url) {
        return this.requestBuilder(method, url);
    }

    public BoundRequestBuilder prepareGet(String url) {
        return this.requestBuilder("GET", url);
    }

    public BoundRequestBuilder prepareConnect(String url) {
        return this.requestBuilder("CONNECT", url);
    }

    public BoundRequestBuilder prepareOptions(String url) {
        return this.requestBuilder("OPTIONS", url);
    }

    public BoundRequestBuilder prepareHead(String url) {
        return this.requestBuilder("HEAD", url);
    }

    public BoundRequestBuilder preparePost(String url) {
        return this.requestBuilder("POST", url);
    }

    public BoundRequestBuilder preparePut(String url) {
        return this.requestBuilder("PUT", url);
    }

    // ...

@reynolek reynolek merged commit c5bc4d8 into Kong:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.