Validate config.json on init #3026
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements configuration validation on CLI initialization to ensure users have valid provider configurations before running commands. The validation enforces that selected providers have proper credentials and shows helpful error messages when configuration is incomplete.
Key changes:
- Added comprehensive config validation with provider-specific credential checking
- Enhanced welcome message to display configuration error instructions
- Modified UI to exit gracefully when configuration is invalid
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cli/src/config/validation.ts | Added provider-specific validation functions and enhanced config validation logic |
| cli/src/state/atoms/config.ts | Added configValidAtom to expose validation results to UI components |
| cli/src/ui/UI.tsx | Integrated config validation checks and exit behavior for invalid configurations |
| cli/src/ui/utils/welcomeMessage.ts | Added function to convert validation errors into user-friendly instructions |
| cli/src/ui/messages/cli/WelcomeMessage.tsx | Enhanced instruction handling to support custom error messages |
| cli/src/config/persistence.ts | Made getConfigPath synchronous and improved merge function documentation |
| Test files | Updated test configurations to use valid credentials that meet new validation requirements |
Context
Resolve: #3000
Implementation
Screenshots
How to Test