Add option to disable drop last on training #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I appreciate your toolbox and I am actively using it!
I have implemented a small change in the data loader construction in
data_manager.pyto force disablingdrop_laston training datasets from the configuration file via the newDISABLE_DROP_LASToption.In some cases, one may not want to drop the last training batch, so this option allows the user to choose so. Note that the original behavior is left untouched by default, as this additional option has to be activated explicitly -- thus, it won't break existing code.
I have implemented it for TRAIN_X, but it may be implemented for TRAIN_U as well.