Upgrade keras 3#1363
Merged
Conversation
calderjo
commented
Feb 8, 2024
forgot to delete this test
Contributor
Author
|
btw had some trouble figuring out git rebase via cli, create a new different branch and forgot to remove the tfjs test, which caused it to failed. it been removed we should expect tests to pass, the o.g branch did pass. |
djherbis
approved these changes
Feb 8, 2024
Contributor
djherbis
left a comment
There was a problem hiding this comment.
Amazing work mate, super cool to see this build/pass tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is based on original rosbo pr for keras-3 to upgrade to keras 3
key things:
http://b/318672158
passes:
https://ci.kaggle.net/job/kernels/job/docker-python/job/upgrade-keras-3/
cc: @jplotts