Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Kristinita
Copy link

@Kristinita Kristinita commented Feb 27, 2017

See also similar pull request.

1. Behavior before pull request

New color scheme User/SashaSublime (SublimePythonIDE).tmTheme create and replace current color scheme in User/Preferences.sublime-settings after Sublime Text restart.

2. Behavior after pull request

New color scheme don't generate and don't replace current color scheme.

3. Reasons

  1. Users may well manually add these lines in tmTheme file of user preferred scheme.
  2. I am color scheme developer. Each time, when I need to change my color scheme, I need change in my User/Preferences.sublime-settings file "color_scheme": "Packages/SashaSublime/SashaSublime.tmTheme" to Packages/User/SashaSublime (SublimePythonIDE).tmTheme. It takes a lot of time.
  3. Some Sublime Text packages also generate own color schemes. Examples:

Each of these packages create own color scheme. But user may use one color scheme. Color changes of other packages don't applied.

  1. I think, is a bad practice — impose user file your color scheme without the user's permission.

4. Alternative

You may add option generate_new_color_scheme_file in settings. If false, new color scheme file don't generate.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.