Add acceptable, neg_pred, not_desc and small_step statuses to get_status#128
Add acceptable, neg_pred, not_desc and small_step statuses to get_status#128tmigot merged 1 commit intoJuliaSmoothOptimizers:mainJuliaSmoothOptimizers/SolverCore.jl:mainfrom
Conversation
|
@tmigot, can you review when you have some time ? Thank you! |
There was a problem hiding this comment.
Pull request overview
This pull request addresses issue #127 by adding support for four missing statuses (acceptable, neg_pred, not_desc, and small_step) to the get_status function. These statuses were already defined in the STATUSES dictionary but were not accessible as keyword arguments in get_status. The PR also adds a type annotation to the prox_unbounded parameter for consistency with other boolean parameters.
Changes:
- Added
acceptable,neg_pred,not_desc, andsmall_stepas keyword arguments toget_statusfunction - Added corresponding status check logic for each new parameter
- Updated function documentation to describe all new parameters
- Added type annotation
::Booltoprox_unboundedparameter for consistency - Added test coverage for all four new status parameters
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/stats.jl | Added four new boolean parameters (acceptable, neg_pred, not_desc, small_step) to get_status function signature, documentation, and control flow logic; added type annotation to prox_unbounded for consistency |
| test/test-stats.jl | Added test cases for the four new status parameters to verify they return the expected status symbols |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 96.93% 93.08% -3.86%
==========================================
Files 4 4
Lines 294 188 -106
==========================================
- Hits 285 175 -110
- Misses 9 13 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmigot
left a comment
There was a problem hiding this comment.
Thanks @MaxenceGollier for the PR!
Related issues
Closes #127
Checklist