Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[WIP] Documentation (take two)#266

Merged
meggart merged 3 commits intomasterJuliaDataCubes/EarthDataLab.jl:masterfrom
fm/docsJuliaDataCubes/EarthDataLab.jl:fm/docsCopy head branch name to clipboard
Apr 13, 2022
Merged

[WIP] Documentation (take two)#266
meggart merged 3 commits intomasterJuliaDataCubes/EarthDataLab.jl:masterfrom
fm/docsJuliaDataCubes/EarthDataLab.jl:fm/docsCopy head branch name to clipboard

Conversation

@MartinuzziFrancesco
Copy link
Copy Markdown
Collaborator

As detailed in #264 this is the same code stored in that PR, only branched from the main repo to access the local builds of the documentation. If this passes docs checks I am going to close #264.

@MartinuzziFrancesco
Copy link
Copy Markdown
Collaborator Author

MartinuzziFrancesco commented Feb 28, 2022

The documenter/deploy is building successfully so I am going to close the other PR as announced.

One problem is that the details are giving me a 404 so probably other steps are needed to look at the docs online.
EDIT: I spoke too soon, docs are deploying just fine.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #266 (d7d81d3) into master (7e26967) will not change coverage.
The diff coverage is n/a.

❗ Current head d7d81d3 differs from pull request most recent head cf4ee4c. Consider uploading reports for the commit cf4ee4c to get more accurate results

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   39.24%   39.24%           
=======================================
  Files          12       12           
  Lines         474      474           
=======================================
  Hits          186      186           
  Misses        288      288           
Impacted Files Coverage Δ
src/ESDL.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e26967...cf4ee4c. Read the comment docs.

@felixcremer
Copy link
Copy Markdown
Member

I just learned, you can click on the details from the documenter/deploy check to get to the preview of the documentation build.

Comment thread docs/make.jl Outdated
"API Documentation" => Any[
"Index" => "API/api_index.md",
"Accessing the Data Cube" => "API/cube_access.md",
"Analisys" => "API/analysis.md",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Analisys" => "API/analysis.md",
"Analysis" => "API/analysis.md",

Comment thread docs/make.jl
Copy link
Copy Markdown
Member

@meggart meggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for starting this. I corrected a small typo and fixed the structure in the examples section. I would propose to merge this as soon as you feel comfortable so we have the URLS etc fixed. We can still improve later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.