Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Reworksavecube fix saving of large cube#130

Merged
meggart merged 2 commits intoJuliaDataCubes:reworksavecubeJuliaDataCubes/EarthDataLab.jl:reworksavecubefrom
felixcremer:reworksavecubefelixcremer/ESDL.jl:reworksavecubeCopy head branch name to clipboard
Aug 27, 2019
Merged

Reworksavecube fix saving of large cube#130
meggart merged 2 commits intoJuliaDataCubes:reworksavecubeJuliaDataCubes/EarthDataLab.jl:reworksavecubefrom
felixcremer:reworksavecubefelixcremer/ESDL.jl:reworksavecubeCopy head branch name to clipboard

Conversation

@felixcremer
Copy link
Copy Markdown
Member

These two changes fixes the problems I had with saving a cube.

@felixcremer felixcremer changed the title Reworksavecube Reworksavecube fix saving of large cube Aug 26, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #130 into reworksavecube will decrease coverage by 0.2%.
The diff coverage is 50%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           reworksavecube     #130      +/-   ##
==================================================
- Coverage           56.41%   56.21%   -0.21%     
==================================================
  Files                  23       23              
  Lines                1877     1875       -2     
==================================================
- Hits                 1059     1054       -5     
- Misses                818      821       +3
Impacted Files Coverage Δ
src/DAT/DAT.jl 85.49% <50%> (-0.52%) ⬇️
src/Proc/CubeIO.jl 92.53% <0%> (-1.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a48b4e...7f15774. Read the comment docs.

@meggart meggart merged commit 87a32d0 into JuliaDataCubes:reworksavecube Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.