feat: add in a timeout option #253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
reviewed
Oct 23, 2023
pdfkit/pdfkit.py
Outdated
Comment on lines
191
to
197
| kwargs = {"input": input} | ||
|
|
||
| # Check if a timeout was specified and pass it along if so | ||
| if self.timeout: | ||
| kwargs["timeout"] = self.timeout | ||
|
|
||
| stdout, stderr = result.communicate(**kwargs) |
There was a problem hiding this comment.
Suggested change
| kwargs = {"input": input} | |
| # Check if a timeout was specified and pass it along if so | |
| if self.timeout: | |
| kwargs["timeout"] = self.timeout | |
| stdout, stderr = result.communicate(**kwargs) | |
| stdout, stderr = result.communicate(input=input, timeout=timeout) |
This should work too?
Author
There was a problem hiding this comment.
Yep works, can't remember exactly why I had wanted to avoid passing a None value.
However the default value for timeout is None, so definitely makes sense to just do this.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
a22cab6 to
9229ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #252