Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 481bd4f

Browse filesBrowse files
authored
Merge pull request python-gitlab#1039 from python-gitlab/fix/set-approvers
Fix/set approvers
2 parents 47cb58c + adc9101 commit 481bd4f
Copy full SHA for 481bd4f

File tree

Expand file treeCollapse file tree

2 files changed

+4
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-3
lines changed
Open diff view settings
Collapse file

‎gitlab/v4/objects.py‎

Copy file name to clipboardExpand all lines: gitlab/v4/objects.py
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2762,12 +2762,13 @@ def set_approvers(
27622762
self._parent.get_id(),
27632763
)
27642764
data = {
2765+
"name": "name",
27652766
"approvals_required": approvals_required,
27662767
"rule_type": "regular",
27672768
"user_ids": approver_ids,
27682769
"group_ids": approver_group_ids,
27692770
}
2770-
self.gitlab.http_put(path, post_data=data, **kwargs)
2771+
self.gitlab.http_post(path, post_data=data, **kwargs)
27712772

27722773

27732774
class ProjectMergeRequestAwardEmoji(ObjectDeleteMixin, RESTObject):
Collapse file

‎tools/ee-test.py‎

Copy file name to clipboardExpand all lines: tools/ee-test.py
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ def end_log():
5656

5757
ars = project1.approvalrules.list(all=True)
5858
assert len(ars) == 0
59-
project.approvalrules.create(
59+
project1.approvalrules.create(
6060
{"name": "approval-rule", "approvals_required": 1, "group_ids": [group1.id]}
6161
)
6262
ars = project1.approvalrules.list(all=True)
6363
assert len(ars) == 1
64-
ars[0].approvals_required == 2
64+
assert ars[0].approvals_required == 2
6565
ars[0].save()
6666
ars = project1.approvalrules.list(all=True)
6767
assert len(ars) == 1

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.