Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: teach JR in tests to parse the response#1437

Merged
bf4 merged 2 commits into
v0-11-devJSONAPI-Resources/jsonapi-resources:v0-11-devfrom
initializersJSONAPI-Resources/jsonapi-resources:initializersCopy head branch name to clipboard
Jan 22, 2024
Merged

feat: teach JR in tests to parse the response#1437
bf4 merged 2 commits into
v0-11-devJSONAPI-Resources/jsonapi-resources:v0-11-devfrom
initializersJSONAPI-Resources/jsonapi-resources:initializersCopy head branch name to clipboard

Conversation

@bf4

@bf4 bf4 commented Jan 22, 2024

Copy link
Copy Markdown
Collaborator

Gems like rspec-openapi rely on response.parsed_body
to work. It also simplifies JR tests a bit, so that's nice, too.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@bf4 bf4 merged commit f193a35 into v0-11-dev Jan 22, 2024
@bf4 bf4 deleted the initializers branch January 22, 2024 20:13
lgebhardt added a commit that referenced this pull request Apr 18, 2024
* feat: teach JR in tests to parse the response

* use response.parsed_body instead of JSON.parse when evaluating responses in tests

---------

Co-authored-by: lgebhardt <larry@cerebris.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.