Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Rails 6.1#1352

Merged
lgebhardt merged 5 commits into
masterJSONAPI-Resources/jsonapi-resources:masterfrom
rails_6.1JSONAPI-Resources/jsonapi-resources:rails_6.1Copy head branch name to clipboard
Jan 20, 2021
Merged

Rails 6.1#1352
lgebhardt merged 5 commits into
masterJSONAPI-Resources/jsonapi-resources:masterfrom
rails_6.1JSONAPI-Resources/jsonapi-resources:rails_6.1Copy head branch name to clipboard

Conversation

@lgebhardt

@lgebhardt lgebhardt commented Jan 19, 2021

Copy link
Copy Markdown
Contributor

Adds support for rails 6.1

Brings in the rails 6.1 work from #1346, fixes a few JoinManager tests to account for new aliasing behavior, and updates the testing matrix. I'd like to rewrite the JoinManger tests, but not for this PR since it will be a lot of time I's rather spend on new features.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt merged commit 1322b59 into master Jan 20, 2021
@lgebhardt lgebhardt deleted the rails_6.1 branch January 20, 2021 18:30
lgebhardt added a commit that referenced this pull request Feb 4, 2021
* Rails v6.1 compatibility (#1346)

* Fixes for rails 6.1.1

* Fixes for ruby 3.0.0

* Remove rails 5.0 support

Co-authored-by: Igor Gonchar <gigorok@gmail.com>

(cherry picked from commit 1322b59)
lgebhardt added a commit that referenced this pull request Feb 4, 2021
* Setup github actions for CI

(cherry picked from commit e894827)

* Rails 6.1 (#1352)

* Rails v6.1 compatibility (#1346)

* Fixes for rails 6.1.1

* Fixes for ruby 3.0.0

* Remove rails 5.0 support

Co-authored-by: Igor Gonchar <gigorok@gmail.com>

(cherry picked from commit 1322b59)
@nadnoslen

Copy link
Copy Markdown

Thanks @lgebhardt! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.