enhancedDate module for Module_2 homework #5
Conversation
9184e07 to
02c3f98
Compare
|
I saw your comment on someone else's assignment that the date object should be created when a method is called, and not when the module is first loaded. Based on that advice, I wrote it as a condition within getDate, but then I realized all the methods required a default so I changed it to a private function and called it in each method. |
There was a problem hiding this comment.
I would just declare two arrays here as separate variables. It will clean up the date.days and date.months syntax which I agree seems a bit verbose. Figuring out when to use a configuration data object is more of a "what looks right" kind of decision. In the case of your days and months, it's clear from their context what they're for. If you have a lot of varied configuration data, having them on an object can help clarify that they're configuration data: config.interval, config.warning, etc.
|
Well done. 👍 |
Hi James,
Here is my assignment. If I went off in the wrong direction at all, could you let me know and I'll redo it? I'm going to go through and add my questions on the lines they pertain to; looking forward to your input!
Thanks,
-JB