Remove uneeded code and dependencies#205
Draft
david-cortes-intel wants to merge 1 commit intoIntelPython:mainIntelPython/scikit-learn_bench:mainfrom
david-cortes-intel:remove_modindavid-cortes-intel/scikit-learn_bench:remove_modinCopy head branch name to clipboard
Draft
Remove uneeded code and dependencies#205david-cortes-intel wants to merge 1 commit intoIntelPython:mainIntelPython/scikit-learn_bench:mainfrom david-cortes-intel:remove_modindavid-cortes-intel/scikit-learn_bench:remove_modinCopy head branch name to clipboard
david-cortes-intel wants to merge 1 commit intoIntelPython:mainIntelPython/scikit-learn_bench:mainfrom
david-cortes-intel:remove_modindavid-cortes-intel/scikit-learn_bench:remove_modinCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is some code trying to deal with moding objects, but those are not used anywhere and it's not clear if it even works. Since moding is not used in any existing configuration, is not a popular library, and is generally not directly supported by scikit-learn, this PR removes both the code and the library dependency on it, which allows to eliminate other transitive dependencies.
Along the way, it also updates pandas parquet code to use pyarrow instead, which is a more commonplace library than
fastparquetand is their default choice. As of pandas3, this explicit dependency on arrow could potentially be dropped since they will have some arrow-related dependencies being mandatory.The PR also drops the dependency on
tabulateas it doesn't appear to be used anywhere in the code or CI scripts, and drops the dependency on FAISS since there are currently no benchmarks for it.Checklist:
Completeness and readability
Testing