Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add runner argument to describe datasets#167

Draft
Alexsandruss wants to merge 2 commits intoIntelPython:mainIntelPython/scikit-learn_bench:mainfrom
Alexsandruss:dev/datasets-describerAlexsandruss/scikit-learn_bench:dev/datasets-describerCopy head branch name to clipboard
Draft

Add runner argument to describe datasets#167
Alexsandruss wants to merge 2 commits intoIntelPython:mainIntelPython/scikit-learn_bench:mainfrom
Alexsandruss:dev/datasets-describerAlexsandruss/scikit-learn_bench:dev/datasets-describerCopy head branch name to clipboard

Conversation

@Alexsandruss
Copy link
Contributor

Description

Add a comprehensive description of proposed changes


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@Alexsandruss Alexsandruss added the enhancement New feature or request label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.