Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 25, 2023. It is now read-only.

Fix ir copy in fallback#61

Merged
AlexanderKalistratov merged 1 commit intoIntelPython:pydpplIntelPython/numba:pydpplfrom
AlexanderKalistratov:akalistr/fix_ir_copyAlexanderKalistratov/numba:akalistr/fix_ir_copyCopy head branch name to clipboard
Oct 8, 2020
Merged

Fix ir copy in fallback#61
AlexanderKalistratov merged 1 commit intoIntelPython:pydpplIntelPython/numba:pydpplfrom
AlexanderKalistratov:akalistr/fix_ir_copyAlexanderKalistratov/numba:akalistr/fix_ir_copyCopy head branch name to clipboard

Conversation

@AlexanderKalistratov
Copy link

@AlexanderKalistratov AlexanderKalistratov commented Oct 6, 2020

Some IR objects can't be deep-copied. This results running some parfors on CPU even if they can be ran on GPU.

@reazulhoque
Copy link

reazulhoque commented Oct 6, 2020

With dpctl master I am getting a segfault:

Current thread 0x00007fc71787ab80 (most recent call first):
  File "/localdisk/work/rhoque/debug_with_context/numba/numba/dppl/target_dispatcher.py", line 28 in __call__
  File "/localdisk/work/rhoque/debug_with_context/numba/numba/dppl/tests/dppl/test_parfor_lower_message.py", line 27 in test_parfor_message
  File "/localdisk/work/rhoque/conda_envs/test_with_context/lib/python3.7/unittest/case.py", line 628 in run
  File "/localdisk/work/rhoque/conda_envs/test_with_context/lib/python3.7/unittest/case.py", line 676 in __call__
  File "/localdisk/work/rhoque/conda_envs/test_with_context/lib/python3.7/unittest/suite.py", line 122 in run
  File "/localdisk/work/rhoque/conda_envs/test_with_context/lib/python3.7/unittest/suite.py", line 84 in __call__
  File "/localdisk/work/rhoque/conda_envs/test_with_context/lib/python3.7/unittest/runner.py", line 176 in run
  File "/localdisk/work/rhoque/debug_with_context/numba/numba/testing/main.py", line 133 in run
  File "/localdisk/work/rhoque/conda_envs/test_with_context/lib/python3.7/unittest/main.py", line 271 in runTests
  File "/localdisk/work/rhoque/debug_with_context/numba/numba/testing/main.py", line 319 in run_tests_real
  File "/localdisk/work/rhoque/debug_with_context/numba/numba/testing/main.py", line 334 in runTests
  File "/localdisk/work/rhoque/conda_envs/test_with_context/lib/python3.7/unittest/main.py", line 101 in __init__
  File "/localdisk/work/rhoque/debug_with_context/numba/numba/testing/main.py", line 173 in __init__
  File "/localdisk/work/rhoque/debug_with_context/numba/numba/testing/__init__.py", line 73 in run_tests
  File "/localdisk/work/rhoque/debug_with_context/numba/numba/testing/_runtests.py", line 26 in _main
  File "/localdisk/work/rhoque/debug_with_context/numba/numba/runtests.py", line 9 in <module>
  File "/localdisk/work/rhoque/conda_envs/test_with_context/lib/python3.7/runpy.py", line 85 in _run_code
  File "/localdisk/work/rhoque/conda_envs/test_with_context/lib/python3.7/runpy.py", line 193 in _run_module_as_main
Segmentation fault (core dumped)```

@AlexanderKalistratov AlexanderKalistratov force-pushed the akalistr/fix_ir_copy branch 2 times, most recently from 550ee45 to a47751d Compare October 7, 2020 19:58
@AlexanderKalistratov
Copy link
Author

AlexanderKalistratov commented Oct 7, 2020

@diptorupd rebased

@AlexanderKalistratov AlexanderKalistratov added this to the beta10 milestone Oct 8, 2020
@AlexanderKalistratov
Copy link
Author

AlexanderKalistratov commented Oct 8, 2020

@diptorupd @reazulhoque I'm merging this one

@AlexanderKalistratov AlexanderKalistratov merged commit 67f2455 into IntelPython:pydppl Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

@reazulhoque reazulhoque Awaiting requested review from reazulhoque

@1e-to 1e-to Awaiting requested review from 1e-to

@PokhodenkoSA PokhodenkoSA Awaiting requested review from PokhodenkoSA

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

beta10

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexanderKalistratov @reazulhoque
Morty Proxy This is a proxified and sanitized view of the page, visit original site.