Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Allow size value where each element is castable to Py_ssize_t#2578

Merged
antonwolfy merged 7 commits intomasterIntelPython/dpnp:masterfrom
resolve-gh-2564IntelPython/dpnp:resolve-gh-2564Copy head branch name to clipboard
Sep 9, 2025
Merged

Allow size value where each element is castable to Py_ssize_t#2578
antonwolfy merged 7 commits intomasterIntelPython/dpnp:masterfrom
resolve-gh-2564IntelPython/dpnp:resolve-gh-2564Copy head branch name to clipboard

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 8, 2025

The PR updates object to tuple logic to align with NumPy and CuPy and to accept any size value passed to random function where each element is castable to Py_ssize_t type. Previously only size value with integer elements was acceptable.

The PR closes #2564.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_31 ran successfully.
Passed: 1226
Failed: 1
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Sep 8, 2025

Coverage Status

coverage: 71.563% (+0.01%) from 71.551%
when pulling a5cd35b on resolve-gh-2564
into 956db4c on master.

dpnp/dpnp_utils/dpnp_algo_utils.pyx Show resolved Hide resolved
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @antonwolfy !

@antonwolfy antonwolfy merged commit 266faed into master Sep 9, 2025
69 of 71 checks passed
@antonwolfy antonwolfy deleted the resolve-gh-2564 branch September 9, 2025 11:07
github-actions bot added a commit that referenced this pull request Sep 9, 2025
)

The PR updates `object to tuple` logic to align with NumPy and CuPy and
to accept any `size` value passed to random function where each element
is castable to `Py_ssize_t` type. Previously only `size` value with
integer elements was acceptable.

The PR closes #2564. 266faed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dpnp.random.random issue with argument types

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.