Use hasattr instead of getattr in checks for convert_item call#2467
Merged
antonwolfy merged 3 commits intomasterIntelPython/dpnp:masterfrom Jun 3, 2025
improve-convert-item-in-testsIntelPython/dpnp:improve-convert-item-in-testsCopy head branch name to clipboard
Merged
Use hasattr instead of getattr in checks for convert_item call#2467antonwolfy merged 3 commits intomasterIntelPython/dpnp:masterfrom improve-convert-item-in-testsIntelPython/dpnp:improve-convert-item-in-testsCopy head branch name to clipboard
hasattr instead of getattr in checks for convert_item call#2467antonwolfy merged 3 commits intomasterIntelPython/dpnp:masterfrom
improve-convert-item-in-testsIntelPython/dpnp:improve-convert-item-in-testsCopy head branch name to clipboard
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.19.0dev0=py312h852cfe9_5 ran successfully. |
ndgrigorian
approved these changes
Jun 3, 2025
antonwolfy
added a commit
that referenced
this pull request
Jun 3, 2025
…2467) The PR improves tests logic to replace unnecessary `getattr` with `hasattr` call to check an item interface.
antonwolfy
added a commit
that referenced
this pull request
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR improves tests logic to replace unnecessary
getattrwithhasattrcall to check an item interface.