Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add a missing event dependency for the strided kernel of erf#2378

Merged
antonwolfy merged 2 commits intomasterIntelPython/dpnp:masterfrom
add-missing-event-dep-in-erf-kernelIntelPython/dpnp:add-missing-event-dep-in-erf-kernelCopy head branch name to clipboard
Mar 21, 2025
Merged

Add a missing event dependency for the strided kernel of erf#2378
antonwolfy merged 2 commits intomasterIntelPython/dpnp:masterfrom
add-missing-event-dep-in-erf-kernelIntelPython/dpnp:add-missing-event-dep-in-erf-kernelCopy head branch name to clipboard

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 21, 2025

The PR proposes to resolve a sporadic failure due to mismatch with the expected data in test_strides.py::test_erf.
The issue looks caused by missing dependency from strided erf kernel on a copy event (produced by copy kernel to transfer the strides of input array from host to device memory).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_39 ran successfully.
Passed: 1005
Failed: 0
Skipped: 45

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.774% (+0.001%) from 71.773%
when pulling 894dd16 on add-missing-event-dep-in-erf-kernel
into 74b5e54 on master.

@antonwolfy antonwolfy merged commit f0aa21d into master Mar 21, 2025
68 checks passed
@antonwolfy antonwolfy deleted the add-missing-event-dep-in-erf-kernel branch March 21, 2025 14:18
github-actions bot added a commit that referenced this pull request Mar 21, 2025
The PR proposes to resolve a sporadic failure due to mismatch with the
expected data in `test_strides.py::test_erf`.
The issue looks caused by missing dependency from strided erf kernel on
a copy event (produced by copy kernel to transfer the strides of input
array from host to device memory). f0aa21d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.