Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

implement dpnp.bitwise_count#2308

Merged
vtavana merged 15 commits intomasterIntelPython/dpnp:masterfrom
impl-bitwise_countIntelPython/dpnp:impl-bitwise_countCopy head branch name to clipboard
Mar 4, 2025
Merged

implement dpnp.bitwise_count#2308
vtavana merged 15 commits intomasterIntelPython/dpnp:masterfrom
impl-bitwise_countIntelPython/dpnp:impl-bitwise_countCopy head branch name to clipboard

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Feb 11, 2025

In this PR, dpnp.bitwise_count is implemented using SYCL built-in function sycl::popcount.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_35 ran successfully.
Passed: 1006
Failed: 0
Skipped: 17

@vtavana vtavana marked this pull request as ready for review February 11, 2025 22:52
dpnp/tests/test_sycl_queue.py Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Feb 14, 2025

Coverage Status

coverage: 71.94% (+0.01%) from 71.929%
when pulling 3451a1e on impl-bitwise_count
into 9d212b3 on master.

@antonwolfy antonwolfy added this to the 0.18.0 release milestone Feb 26, 2025
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana. Only one more minor comment from.

dpnp/tests/test_usm_type.py Show resolved Hide resolved
@vtavana vtavana merged commit b91e43b into master Mar 4, 2025
65 of 67 checks passed
@vtavana vtavana deleted the impl-bitwise_count branch March 4, 2025 20:19
github-actions bot added a commit that referenced this pull request Mar 4, 2025
In this PR, `dpnp.bitwise_count` is implemented using [SYCL built-in
function](https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#api:popcount)
`sycl::popcount`. b91e43b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.