Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Move dpnp.from_dlpack to array creation routine#2209

Merged
antonwolfy merged 8 commits intomasterIntelPython/dpnp:masterfrom
move-from_dlpack-to-array-creation-routineIntelPython/dpnp:move-from_dlpack-to-array-creation-routineCopy head branch name to clipboard
Dec 5, 2024
Merged

Move dpnp.from_dlpack to array creation routine#2209
antonwolfy merged 8 commits intomasterIntelPython/dpnp:masterfrom
move-from_dlpack-to-array-creation-routineIntelPython/dpnp:move-from_dlpack-to-array-creation-routineCopy head branch name to clipboard

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 3, 2024

The PR proposes to move dpnp.from_dlpack function to dpnp/dpnp_iface_arraycreation.py and to update docstring description, because there were formatting issues with rendered documentation of dpnp.from_dlpack.

Also sphinx configuration was tuned to add mapping towards dpctl documentation pages.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Dec 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the move-from_dlpack-to-array-creation-routine branch from 7d1c321 to 1e29cef Compare December 4, 2024 15:07
@antonwolfy antonwolfy marked this pull request as ready for review December 4, 2024 19:35
Copy link
Contributor

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

dpnp/dpnp_iface_arraycreation.py Outdated Show resolved Hide resolved
Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com>
@antonwolfy antonwolfy merged commit e53fa72 into master Dec 5, 2024
@antonwolfy antonwolfy deleted the move-from_dlpack-to-array-creation-routine branch December 5, 2024 12:17
github-actions bot added a commit that referenced this pull request Dec 5, 2024
The PR proposes to move `dpnp.from_dlpack` function to
`dpnp/dpnp_iface_arraycreation.py` and to update docstring description,
because there were formatting issues within rendered documentation of
`dpnp.from_dlpack`.

Also sphinx configuration was tuned to add mapping towards dpctl
documentation pages. e53fa72
antonwolfy added a commit that referenced this pull request Dec 6, 2024
The PR proposes to move `dpnp.from_dlpack` function to
`dpnp/dpnp_iface_arraycreation.py` and to update docstring description,
because there were formatting issues within rendered documentation of
`dpnp.from_dlpack`.

Also sphinx configuration was tuned to add mapping towards dpctl
documentation pages.
@antonwolfy antonwolfy mentioned this pull request Dec 6, 2024
6 tasks
github-actions bot added a commit that referenced this pull request Dec 6, 2024
antonwolfy added a commit that referenced this pull request Dec 6, 2024
This PR backports of #2209 from development branch to
`maintenance/0.16.x`.
github-actions bot added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.