Implementation of correlate#2180
Merged
AlexanderKalistratov merged 9 commits intomasterIntelPython/dpnp:masterfrom Dec 9, 2024
Merged
Implementation of correlate#2180AlexanderKalistratov merged 9 commits intomasterIntelPython/dpnp:masterfrom
AlexanderKalistratov merged 9 commits intomasterIntelPython/dpnp:masterfrom
Conversation
256eac3 to
10beeea
Compare
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
fa3162b to
6c4fb26
Compare
vtavana
reviewed
Nov 18, 2024
5f793ab to
2514037
Compare
fbc94d0 to
fa3af10
Compare
antonwolfy
reviewed
Dec 3, 2024
antonwolfy
reviewed
Dec 3, 2024
fa3af10 to
70a7d8d
Compare
be09e32 to
91fd41f
Compare
91fd41f to
943726f
Compare
antonwolfy
reviewed
Dec 9, 2024
antonwolfy
approved these changes
Dec 9, 2024
Contributor
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @AlexanderKalistratov , LGTM
github-actions bot
added a commit
that referenced
this pull request
Dec 9, 2024
* Implementation of dot product sliding window which is can be used to implement both `correlate` and `convolve` functions. * Implementation of `correlate` function using dot product sliding window be6e00f
AlexanderKalistratov
added a commit
that referenced
this pull request
Feb 4, 2025
* Added keyword `method` to `correlate` function similar to [scipy correlate](https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.correlate.html) * If `method == 'auto'` method is choosing automatically between `direct` and `fft` * Added implementation of fft-based correlation * fft-based implementation may have accuracy issues, so it is validated in non-standard way. Depends on: #2180, #2202 --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Feb 4, 2025
* Added keyword `method` to `correlate` function similar to [scipy correlate](https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.correlate.html) * If `method == 'auto'` method is choosing automatically between `direct` and `fft` * Added implementation of fft-based correlation * fft-based implementation may have accuracy issues, so it is validated in non-standard way. Depends on: #2180, #2202 --------- Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> da2eeba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correlateandconvolvefunctions.correlatefunction using dot product sliding window