Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add dpnp.byte_bounds implementation#2155

Merged
antonwolfy merged 4 commits intomasterIntelPython/dpnp:masterfrom
impl/byte_boundsIntelPython/dpnp:impl/byte_boundsCopy head branch name to clipboard
Nov 12, 2024
Merged

Add dpnp.byte_bounds implementation#2155
antonwolfy merged 4 commits intomasterIntelPython/dpnp:masterfrom
impl/byte_boundsIntelPython/dpnp:impl/byte_boundsCopy head branch name to clipboard

Conversation

@ekomarova
Copy link
Contributor

@ekomarova ekomarova commented Nov 7, 2024

This PR adds the implementation of dpnp.byte_bounds

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

dpnp/dpnp_iface_utils.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_utils.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_utils.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_utils.py Show resolved Hide resolved
dpnp/dpnp_iface_utils.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_utils.py Show resolved Hide resolved
tests/test_usm_utils.py Outdated Show resolved Hide resolved
tests/test_usm_utils.py Outdated Show resolved Hide resolved
tests/test_usm_utils.py Outdated Show resolved Hide resolved
tests/test_usm_utils.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_utils.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_utils.py Outdated Show resolved Hide resolved
tests/third_party/cupy/misc_tests/test_byte_bounds.py Outdated Show resolved Hide resolved
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @ekomarova for the contribution. I have only minor comment, but in overall LGTM!

dpnp/dpnp_iface_utils.py Outdated Show resolved Hide resolved
@antonwolfy antonwolfy merged commit 11f251d into master Nov 12, 2024
@antonwolfy antonwolfy deleted the impl/byte_bounds branch November 12, 2024 17:15
github-actions bot added a commit that referenced this pull request Nov 12, 2024
* Add dpnp.byte_bounds implementation

* Update func description to render the doc correctly

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 11f251d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.