Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Implementing histogramdd#2143

Merged
AlexanderKalistratov merged 7 commits intoIntelPython:masterIntelPython/dpnp:masterfrom
AlexanderKalistratov:histogramddAlexanderKalistratov/dpnp:histogramddCopy head branch name to clipboard
Dec 8, 2024
Merged

Implementing histogramdd#2143
AlexanderKalistratov merged 7 commits intoIntelPython:masterIntelPython/dpnp:masterfrom
AlexanderKalistratov:histogramddAlexanderKalistratov/dpnp:histogramddCopy head branch name to clipboard

Conversation

@AlexanderKalistratov
Copy link
Collaborator

@AlexanderKalistratov AlexanderKalistratov commented Oct 31, 2024

Implementing histogramdd

@AlexanderKalistratov AlexanderKalistratov force-pushed the histogramdd branch 2 times, most recently from 404f0fe to a108da7 Compare November 15, 2024 04:42
antonwolfy
antonwolfy reviewed Nov 19, 2024
View reviewed changes
dpnp/dpnp_iface_histograms.py Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Nov 19, 2024
View reviewed changes
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Nov 19, 2024
View reviewed changes
dpnp/backend/extensions/statistics/common.hpp Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Nov 19, 2024
View reviewed changes
dpnp/backend/extensions/statistics/common.hpp Outdated Show resolved Hide resolved
dpnp/backend/extensions/statistics/common.hpp Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Nov 19, 2024
View reviewed changes
dpnp/backend/extensions/statistics/histogram_common.hpp Show resolved Hide resolved
dpnp/backend/extensions/statistics/histogram_common.hpp Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Nov 19, 2024
View reviewed changes
dpnp/backend/extensions/statistics/histogramdd.hpp Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Nov 19, 2024
View reviewed changes
dpnp/backend/extensions/statistics/histogramdd.cpp Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Nov 19, 2024
View reviewed changes
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
@AlexanderKalistratov AlexanderKalistratov force-pushed the histogramdd branch 3 times, most recently from dd1fca3 to 6a7efb0 Compare November 28, 2024 22:30
@AlexanderKalistratov
Copy link
Collaborator Author

AlexanderKalistratov commented Nov 29, 2024

@antonwolfy please re-review PR

antonwolfy
antonwolfy reviewed Dec 3, 2024
View reviewed changes
dpnp/backend/extensions/statistics/common.hpp Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/tests/third_party/cupy/statistics_tests/test_histogram.py Outdated Show resolved Hide resolved
dpnp/tests/third_party/cupy/statistics_tests/test_histogram.py Outdated Show resolved Hide resolved
@AlexanderKalistratov AlexanderKalistratov force-pushed the histogramdd branch 4 times, most recently from 60776e8 to aec799c Compare December 4, 2024 14:21
@AlexanderKalistratov
Copy link
Collaborator Author

AlexanderKalistratov commented Dec 4, 2024

@antonwolfy please re-review pr

antonwolfy
antonwolfy reviewed Dec 4, 2024
View reviewed changes
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/tests/third_party/cupy/statistics_tests/test_histogram.py Outdated Show resolved Hide resolved
@AlexanderKalistratov
Copy link
Collaborator Author

AlexanderKalistratov commented Dec 6, 2024

@antonwolfy

The tests failed due to result type mismatch when running with numpy 2.1.
It seems numpy uses different type promotion in the latest version. Is there something we should align with?
Otherwise we have to keep type_check=False.

The actual issue was in returned bins, and not histogram. We are casting all incoming bins and sample to the same type. Originally we were returning this casted bins.

Now if ndarray was passed as part of bins we are returning this original array instead of casted one.

antonwolfy
antonwolfy approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AlexanderKalistratov, LGTM!

@AlexanderKalistratov AlexanderKalistratov merged commit 0bfe1e3 into IntelPython:master Dec 8, 2024
github-actions bot added a commit that referenced this pull request Dec 8, 2024
@github-actions
Implementing histogramdd (#2143)
e83c2fa 
Implementation of histogramdd 0bfe1e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexanderKalistratov @antonwolfy
Morty Proxy This is a proxified and sanitized view of the page, visit original site.