Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Leverage on dpctl.tensor implementation in dpnp.put_along_axis#2134

Merged
antonwolfy merged 5 commits intomasterIntelPython/dpnp:masterfrom
dpctl-put_along_axisIntelPython/dpnp:dpctl-put_along_axisCopy head branch name to clipboard
Nov 1, 2024
Merged

Leverage on dpctl.tensor implementation in dpnp.put_along_axis#2134
antonwolfy merged 5 commits intomasterIntelPython/dpnp:masterfrom
dpctl-put_along_axisIntelPython/dpnp:dpctl-put_along_axisCopy head branch name to clipboard

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 29, 2024 •
edited
Loading

The PR proposes to leverage on dpctl.tensor implementation in dpnp.put_along_axis function.
Additionally, the function signature is extended with new keyword mode to provide a control how out-of-bounds indices will be handled.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Oct 29, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review October 30, 2024 11:07
vtavana
vtavana approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

dpnp/dpnp_iface_indexing.py Show resolved Hide resolved
@antonwolfy antonwolfy merged commit 2c4f3b5 into master Nov 1, 2024
@antonwolfy antonwolfy deleted the dpctl-put_along_axis branch November 1, 2024 00:13
github-actions bot added a commit that referenced this pull request Nov 1, 2024
@github-actions
Leverage on dpctl.tensor implementation in dpnp.put_along_axis (#2134)
c2803af 
* Implement dpnp.put_along_axis through dpctl.tensor

* Increase test coverage

* Update dpnp/dpnp_iface_indexing.py

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>

* Add empty lines per review comment

---------

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> 2c4f3b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

1 more reviewer

@vtavana vtavana vtavana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonwolfy @vtavana
Morty Proxy This is a proxified and sanitized view of the page, visit original site.