Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Implement dpnp.array_equal and dpnp.array_equiv#1965

Merged
antonwolfy merged 7 commits intomasterIntelPython/dpnp:masterfrom
impl_array_equalIntelPython/dpnp:impl_array_equalCopy head branch name to clipboard
Aug 9, 2024
Merged

Implement dpnp.array_equal and dpnp.array_equiv#1965
antonwolfy merged 7 commits intomasterIntelPython/dpnp:masterfrom
impl_array_equalIntelPython/dpnp:impl_array_equalCopy head branch name to clipboard

Conversation

@npolina4
Copy link
Contributor

@npolina4 npolina4 commented Aug 2, 2024

Implement dpnp.array_equal and dpnp.array_equiv.

Added tests from numpy.
Unmuted test from tests/third_party/cupy/logic_tests/test_comparison.py

Added CFD and tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

dpnp/dpnp_iface_logic.py Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
tests/test_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Show resolved Hide resolved
tests/test_logic.py Show resolved Hide resolved
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4 , no more comments from me

@antonwolfy antonwolfy merged commit 7948a0a into master Aug 9, 2024
@antonwolfy antonwolfy deleted the impl_array_equal branch August 9, 2024 09:31
github-actions bot added a commit that referenced this pull request Aug 9, 2024
* Implement dpnp.array_equal and dpnp.array_equiv

* Added CFD

* Applied review comments

* Added tests

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 7948a0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.