Get rid of call_origin in dpnp.where#1760
Merged
antonwolfy merged 3 commits intomasterIntelPython/dpnp:masterfrom Mar 28, 2024
remove-fall-back-on-numpy-in-whereIntelPython/dpnp:remove-fall-back-on-numpy-in-whereCopy head branch name to clipboard
Merged
Get rid of call_origin in dpnp.where#1760antonwolfy merged 3 commits intomasterIntelPython/dpnp:masterfrom remove-fall-back-on-numpy-in-whereIntelPython/dpnp:remove-fall-back-on-numpy-in-whereCopy head branch name to clipboard
call_origin in dpnp.where#1760antonwolfy merged 3 commits intomasterIntelPython/dpnp:masterfrom
remove-fall-back-on-numpy-in-whereIntelPython/dpnp:remove-fall-back-on-numpy-in-whereCopy head branch name to clipboard
Conversation
Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vlad-perevezentsev
approved these changes
Mar 28, 2024
Contributor
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM!
Thank you @antonwolfy
vtavana
reviewed
Mar 28, 2024
antonwolfy
added a commit
that referenced
this pull request
Mar 28, 2024
antonwolfy
added a commit
that referenced
this pull request
Apr 1, 2024
* Get rid of call_origin in dpnp.nonzero * Applied review comments from #1760 * Removed dppy/label/coverage channel for coverage run * Rolled back dppy/label/coverage channel * Updated note comment in description
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Apr 2, 2024
* Get rid of call_origin in dpnp.nonzero * Applied review comments from IntelPython#1760 * Removed dppy/label/coverage channel for coverage run * Rolled back dppy/label/coverage channel * Updated note comment in description a134bdc
vtavana
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Get rid of call_origin in dpnp.nonzero * Applied review comments from #1760 * Removed dppy/label/coverage channel for coverage run * Rolled back dppy/label/coverage channel * Updated note comment in description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That PR propose to remove
call_origincall fromdpnp.wherefunction.Also the PR adds more tests (including missing ones for compute follows data support) and increases coverage rate.