Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

update dpnp.cross#1715

Merged
antonwolfy merged 6 commits intomasterIntelPython/dpnp:masterfrom
dpnp_crossIntelPython/dpnp:dpnp_crossCopy head branch name to clipboard
Feb 21, 2024
Merged

update dpnp.cross#1715
antonwolfy merged 6 commits intomasterIntelPython/dpnp:masterfrom
dpnp_crossIntelPython/dpnp:dpnp_crossCopy head branch name to clipboard

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Feb 16, 2024

In this PR, dpnp.cross is updated using existing functions in dpnp.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana vtavana marked this pull request as ready for review February 16, 2024 02:42
antonwolfy
antonwolfy reviewed Feb 16, 2024
View reviewed changes
dpnp/dpnp_algo/dpnp_algo_mathematical.pxi Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
tests/test_product.py Outdated Show resolved Hide resolved
tests/test_product.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@antonwolfy antonwolfy merged commit 95fdbec into master Feb 21, 2024
@antonwolfy antonwolfy deleted the dpnp_cross branch February 21, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana @antonwolfy
Morty Proxy This is a proxified and sanitized view of the page, visit original site.