Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Redesign dpnp.put_along_axis and dpnp.take_along_axis thorough existing calls#1636

Merged
antonwolfy merged 4 commits intomasterIntelPython/dpnp:masterfrom
put_take_along_axisIntelPython/dpnp:put_take_along_axisCopy head branch name to clipboard
Dec 6, 2023
Merged

Redesign dpnp.put_along_axis and dpnp.take_along_axis thorough existing calls#1636
antonwolfy merged 4 commits intomasterIntelPython/dpnp:masterfrom
put_take_along_axisIntelPython/dpnp:put_take_along_axisCopy head branch name to clipboard

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 4, 2023

The PR proposes to implement dpnp.put_along_axis and dpnp.take_along_axis functions through building a fancy index.
The indexing functionality will be used to either replace the values in an input array based on the index or to extract the values following the fancy index.
The PR continues the work started with updating dpnp.put and dpnp.take functions to leverage on dpctl.tensor implementation for indexing routine.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Dec 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy requested review from vlad-perevezentsev and vtavana and removed request for vtavana December 4, 2023 21:24
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
tests/test_sycl_queue.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit a7add8e into master Dec 6, 2023
@antonwolfy antonwolfy deleted the put_take_along_axis branch December 6, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.