Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add_real_imag#1557

Merged
vlad-perevezentsev merged 5 commits intomasterIntelPython/dpnp:masterfrom
real_imag_dpctl_to_dpnpIntelPython/dpnp:real_imag_dpctl_to_dpnpCopy head branch name to clipboard
Sep 25, 2023
Merged

add_real_imag#1557
vlad-perevezentsev merged 5 commits intomasterIntelPython/dpnp:masterfrom
real_imag_dpctl_to_dpnpIntelPython/dpnp:real_imag_dpctl_to_dpnpCopy head branch name to clipboard

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Sep 12, 2023

In this PR, we implement dpnp.real and dpnp.imag using their counterpart in dpctl, i.e., dpctl.tensor.real and dpctl.tensor.imag.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Sep 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review September 13, 2023 00:33
dpnp/dpnp_algo/dpnp_elementwise_common.py Outdated Show resolved Hide resolved
dpnp/dpnp_algo/dpnp_elementwise_common.py Outdated Show resolved Hide resolved
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
@vtavana vtavana force-pushed the real_imag_dpctl_to_dpnp branch from 304c986 to 43e66cc Compare September 14, 2023 17:43
tests/skipped_tests.tbl Show resolved Hide resolved
tests/skipped_tests.tbl Show resolved Hide resolved
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thank you @vtavana

dpnp/dpnp_array.py Show resolved Hide resolved
dpnp/dpnp_array.py Show resolved Hide resolved
@vtavana
Copy link
Contributor Author

vtavana commented Sep 18, 2023

I had not paid attention to the fact that numpy.real and numpy.imag only accept one input. I have also modified the dpnp implementation to replicate this feature. Previous implementation could cause a problem when origin implementation ( call_origin ) was called.

@vlad-perevezentsev vlad-perevezentsev merged commit 329f36e into master Sep 25, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the real_imag_dpctl_to_dpnp branch September 25, 2023 13:30
@antonwolfy antonwolfy mentioned this pull request May 31, 2024
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.